[fast/warm-reboot] Retain TRANSCEIVER_INFO tables on fast/warm-reboot #3240
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stepan Blyschak <[email protected]>
|
@mihirpat1 @vaibhavhd please review |
prgeor
reviewed
Mar 25, 2024
scripts/fast-reboot
Outdated
| @@ -252,6 +252,8 @@ function backup_database() | |||
| and not string.match(k, 'MIRROR_SESSION_TABLE|') \ | |||
| and not string.match(k, 'FG_ROUTE_TABLE|') \ | |||
| and not string.match(k, 'WARM_RESTART_ENABLE_TABLE|') \ | |||
| and not string.match(k, 'TRANSCEIVER_INFO|') \ | |||
| and not string.match(k, 'TRANSCEIVER_STATUS|') \ | |||
There was a problem hiding this comment.
@stepanblyschak OA subscribes to TRANSCEIVER_INFO, why save TRANSCIEVER_STATUS?
prgeor
requested changes
Apr 8, 2024
There was a problem hiding this comment.
@stepanblyschak As discussed offline, lets fix your platform API so that Xcvrd can identify already present transceivers.
stepanblyschak
changed the title
|
@prgeor removed TRANSCEIVER_STATUS |
noaOrMlnx
approved these changes
Apr 16, 2024
prgeor
approved these changes
Apr 19, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-utilities
that referenced
this pull request
May 13, 2024
…sonic-net#3240) * [fast/warm-reboot] Retain TRANSCEIVER_INFO/STATUS tables on reboot Signed-off-by: Stepan Blyschak <[email protected]> * Remove TRANSCEIVER_STATUS --------- Signed-off-by: Stepan Blyschak <[email protected]>
|
Cherry-pick PR to 202311: #3319 |
mssonicbld
pushed a commit
that referenced
this pull request
May 13, 2024
…#3240) * [fast/warm-reboot] Retain TRANSCEIVER_INFO/STATUS tables on reboot Signed-off-by: Stepan Blyschak <[email protected]> * Remove TRANSCEIVER_STATUS --------- Signed-off-by: Stepan Blyschak <[email protected]>
mssonicbld
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
arfeigin
pushed a commit
to arfeigin/sonic-utilities
that referenced
this pull request
Jun 16, 2024
…sonic-net#3240) * [fast/warm-reboot] Retain TRANSCEIVER_INFO/STATUS tables on reboot Signed-off-by: Stepan Blyschak <[email protected]> * Remove TRANSCEIVER_STATUS --------- Signed-off-by: Stepan Blyschak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Retain TRANSCEIVER_INFO tables on fast/warm reboot. The PHY isn't reset on fast/warm reboot. Knowing about plugged modules is required for orchagent to set SAI_PORT_ATTR_HOST_TX_SIGNAL_ENABLE=true on start.
How I did it
Save TRANSCEIVER_INFO tables on warm/fast-reboot.
How to verify it
Run fast/warm-reboot.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)